httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: [PATCH] update brigade buffering.
Date Fri, 09 Feb 2001 03:04:36 GMT

> > > If you call apr_brigade_write on a brigade with no flush function 
> > > specified, then you're going to end up with a transient bucket in 
> > > your brigade.  It looks like check_brigade_flush needs to check 
> > > b->flush and create a heap bucket if it's NULL.  I thought about 
> > > having apr_brigade_write checking  b->flush before calling 
> > > check_brigade_flush, but that could lead to buffer overruns.
> > 
> > Good point.  I'll make that change.
> 
> I get the feeling that you tune out my email messages. I've said several
> times so far (most recently just earlier today) that the brigade stuff
> cannot return transient buckets. It must create a heap bucket, or it must
> flush the transient buckets.
> 
> Greg Marr mentions it, and you hop to it.
> 
> It is rather disconcerting.

It has nothing to do with tuning you out.  Take a look at how much this
patch has changed due to your comments.  You say the code can't return
transient buckets, it has to either flush or use heap.  Due to that, I
made the code flush whenever it uses transient buckets.  Greg pointed out
a small bug where we we returned a transient bucket when we couldn't
flush.  This was me missing a case when dealing with your point, not
ignoring you.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message