httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject socket_read?
Date Sat, 17 Feb 2001 18:25:05 GMT
the end of socket_read (in apr-util/buckets/apr_buckets_socket.c) looks
like this:

    if (*len > 0) {
        b = apr_bucket_socket_create(p);
	APR_BUCKET_INSERT_AFTER(a, b);
    }
    else if (rv == APR_EOF && block == APR_NONBLOCK_READ) {
        return APR_EOF;
    }
    return APR_SUCCESS;
}

why the test for APR_NONBLOCK_READ? Surely an EOF is an EOF, whatever
mode you are in? Shouldn't it just return APR_EOF if rv == APR_EOF,
regardless of mode?

Cheers,

Ben.

--
http://www.apache-ssl.org/ben.html

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff

Mime
View raw message