httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: [Patch]: Update of the code to move cgi stuff from mod_include to mod_cgi(d)
Date Mon, 05 Feb 2001 17:49:15 GMT
"Paul J. Reder" wrote:
> 
> Ben Laurie wrote:
> > BTW, one minor criticism: it is eccentric (though not incorrect) to
> > fetch a pointer to your own optional function, as mod_include does in
> > this patch!
> 
> This was done intentionally. I felt it was a good idea to use the method I
> expected others to use so that 1) there was an example of how other code
> is expected to use mod_include's functions (even if cgi stuff changed)
> and 2) provide a constant test of the current code status (i.e. if it gets
> broken in the future, mod_include is the first to know about it - regardless
> of whether cgi or other users are installed or not).
> 
> It didn't seem to be a performance hit and thus seemed to be more win than
> lose.

Right - the performance hit is tiny (call through a pointer instead of
directly). It may be worth commenting that the behaviour was done for
debugging/demo rather than because it is required.

Cheers,

Ben.

--
http://www.apache-ssl.org/ben.html

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff

Mime
View raw message