httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apr/network_io/unix sendrecv.c
Date Tue, 27 Feb 2001 00:19:49 GMT
On Mon, Feb 26, 2001 at 02:25:26PM -0800, rbb@covalent.net wrote:
> On Mon, 26 Feb 2001, William A. Rowe, Jr. wrote:
>...
> > if you are hanging out mod_core.h for a few days - could it _please_ move to
> > httpd-2.0/include till you finish and it gets its privacy back?
> 
> I would REALLY like to not move it.  The problem is that moving this file
> back and forth means that we are likely to mess up the history.  I would
> prefer to just expose it and then hide it.

I'm with Ryan on this one.

> > Second...
> >
> > can we do _something_ about the symbol switching you have going on?  I see
> > a bunch of missing AP_DECLARE()'s - or a few too many.  I can't grok if these
> > fns will become private and restricted to mod_core, and never move around,
> > or if they will be accessable.  If they are supposed to be accessable, even
> > to 'intimate' modules like loadable protocols, please put the AP_DECLARE()s
> > back in ... otoh if they will not be exported please remove the AP_DECLARE()s
> > from the header.
> 
> I did not remove ANY AP_DECLARE's, nor do I plan to.  I will do my best to
> put them in if necessary, but I am just moving stuff that is already
> there, so if it has the wrong linkage when I am done, it had the wrong
> linkage when I started.

And again here. It is safer to leave them as is for now. Upon completion, it
will be more obvious how to sort them out.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message