httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: httpd-2.0/server util_filter.c
Date Fri, 09 Feb 2001 11:19:33 GMT
On Fri, Feb 09, 2001 at 07:04:52AM -0000, rbb@apache.org wrote:
>...
>   --- util_filter.h	2001/02/03 20:25:13	1.38
>   +++ util_filter.h	2001/02/09 07:04:51	1.39
>...
>   +/**
>   + * Write an unspecified number of strings to the current filter
>   + * @param f the filter to write to
>   + * @param bb The brigade to buffer into
>   + * @param ... The strings to write
>   + * @deffunc int ap_fputs(ap_filter_t *f, apr_bucket_brigade *bb, ...);
>   + */
>   +#define ap_fvputs(f, bb, args...) \
>   +	apr_brigade_putstrs(bb, filter_flush, f->next, ##args)
>   +
>   +/**
>   + * Output data to the filter in printf format
>   + * @param f the filter to write to
>   + * @param bb The brigade to buffer into
>   + * @param fmt The format string
>   + * @param ... The argumets to use to fill out the format string
>   + * @deffunc int ap_fputs(ap_filter_t *f, apr_bucket_brigade *bb, const char *fmt,
...);
>   + */
>   +#define ap_fprintf(f, bb, fmt, args...) \
>   +	apr_brigade_printf(bb, filter_flush, f->next, fmt, ##args)

I'm a bit concerned about these two macros. GCC is saying they are non-ANSI.
Could people test them out on their compilers? I suspect we may need to
convert these two to real functions.

[ that said: the feature is sweet... no idea it existed! ]

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message