httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <>
Subject Re: [PATCH] update brigade buffering.
Date Fri, 09 Feb 2001 02:03:12 GMT
On Thu, Feb 08, 2001 at 04:54:38PM -0800, wrote:
> > If you call apr_brigade_write on a brigade with no flush function 
> > specified, then you're going to end up with a transient bucket in 
> > your brigade.  It looks like check_brigade_flush needs to check 
> > b->flush and create a heap bucket if it's NULL.  I thought about 
> > having apr_brigade_write checking  b->flush before calling 
> > check_brigade_flush, but that could lead to buffer overruns.
> Good point.  I'll make that change.

I get the feeling that you tune out my email messages. I've said several
times so far (most recently just earlier today) that the brigade stuff
cannot return transient buckets. It must create a heap bucket, or it must
flush the transient buckets.

Greg Marr mentions it, and you hop to it.

It is rather disconcerting.


Greg Stein,

View raw message