httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: cvs commit: httpd-2.0/server/mpm/winnt mpm.h mpm_default.h mpm_winnt.c mpm_winnt.h
Date Sat, 03 Feb 2001 01:30:36 GMT
stoddard@apache.org wrote:
> 
>    
>   -    ap_sync_scoreboard_image();
>   +/*    ap_sync_scoreboard_image(); */
>        for (i = 0; i < HARD_SERVER_LIMIT; ++i) {

We don't need to sync?

>   
>   1.2       +71 -11    httpd-2.0/server/scoreboard.c
>   
>   Index: scoreboard.c
>    
>    #if APR_HAS_SHARED_MEMORY
>    #include "apr_shmem.h"
>   -
>    static apr_shmem_t *scoreboard_shm = NULL;
>   -
>   +#endif
>   +/*
>   + * ToDo:
>   + * This function should be renamed to cleanup_shared
>   + * and it should handle cleaning up a scoreboard shared
>   + * between processes using any form of IPC (file, shared memory
>   + * segment, etc.). Leave it as is now because it is being used
>   + * by various MPMs. 
>   + */
>    apr_status_t ap_cleanup_shared_mem(void *d)
>    {
>   +#if APR_HAD_SHARED_MEMORY

Should that be APR_HAS_SHARED_MEMORY ??
                   ---

>   +#if APR_HAD_SHARED_MEMORY

ditto here


-- 
===========================================================================
   Jim Jagielski   [|]   jim@jaguNET.com   [|]   http://www.jaguNET.com/
          "Casanova will have many weapons; To beat him you will
              have to have more than forks and flatulence."

Mime
View raw message