httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <>
Subject Re: [PATCH] Fix 1.3.17 crash in util_uri.c, etc.
Date Fri, 16 Feb 2001 23:47:30 GMT
From: "Jeffrey W. Baker" <>
Sent: Friday, February 16, 2001 5:02 PM

> On Fri, 16 Feb 2001, William A. Rowe, Jr. wrote:
> > Fill in the missing components with a constant empty string, balance the elements
> > as you are already doing, and then merging the list of members rather than
> > incrementing a string array index through the pieces?
> >
> > I'm thinking pure legibility here.
> I took a whack at it and the logic is more twisted than my version.  I
> don't like having to make a decision, flag it in a struct, then make the
> decision again later.  Also I wound up adding the delimiters using
> conditionals inside ap_pstrcat(), which is partly what I didn't like about
> the original version.
> So, my previous patch is my best effort.

Thanks for whacking at it.

Jim is +1 the first patch with no default.

I'm +1 the second patch, and doubly so since it's what you -will- do in the full
blown patch (default to "http").

Can someone break this tie, please :-)  I think Jim and I will both live with
the majority's voice on this.


View raw message