httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: [PATCH] Fix 1.3.17 crash in util_uri.c, etc.
Date Fri, 16 Feb 2001 21:22:58 GMT
From: "Jeffrey W. Baker" <jwbaker@acm.org>
Sent: Friday, February 16, 2001 3:20 PM


> >       uri_components retptr,
> >       retptr = *uptr;
> >
> > Fill in the missing components with a constant empty string, balance the elements
> > as you are already doing, and then merging the list of members rather than
> > incrementing a string array index through the pieces?
> >
> > I'm thinking pure legibility here.
> 
> I'll look into it.  I wrote the routine this way for two reasons.  With
> the array, you can easily track the URI being built in a gdb session.
> Also, the uri_components structure doesn't have any places for the
> delimiters.

Correct, :// would have to be appended to the scheme or prepended to the host
name with ap_pstrcat, but expected that was the most legible method.


Mime
View raw message