httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <>
Subject Re: [PATCH] final part of the ap_r* solution
Date Wed, 14 Feb 2001 02:13:45 GMT
From: "Greg Stein" <>
Sent: Tuesday, February 13, 2001 7:58 PM

> On Tue, Feb 13, 2001 at 09:42:00AM -0600, William A. Rowe, Jr. wrote:
> > From: "Greg Stein" <>
> >...
> > > If we want it in before beta, then I can build the patch. The ap_r* code
> > > already works fine, so we certainly aren't gaining functionality for the
> > > beta. It should be changed in the long run, though.
> > 
> > The 'beta' is the wakeup call to module authors to "get your ass over here.'
> > Whatever we do - we had better remain fairly consistent from here on out to release.
> Ryan's patch changes the API, so it would have to go in before beta.
> My (theoretical) patch to switch OLD_WRITE from an internal buffer to use
> the new brigade buffering has no impact on the API at all. It can happen
> before or after beta.

Please apply said patch ASAP.  We will not keep OLD_WRITE using the internal buffer,
so if this patch performs over the r->bb, or the moral majority believes that r->bb
is a wrong solution, it would have to happen anyways.

I am still firmly against yet another filter (a la coalesce) to do what the top/bottom
end designs should already handle.  But if the OLD_WRITE filter stays, and for benchmarking
apples to apples, it clearly needs to be updated to the new r/w bucket mechanism.

> Unrelated: I believe we can change APIs after the beta if we want. We're
> trying to build a great product; if an API change is needed to do that, then
> we should. We certainly don't want to change broad architecture -- that
> would definitely screw third-party module developers, but API changes are
> manageable.

We should change the API if we -NEED- to, but I'd like to know that we are strongly
encouraging module authors to start building solid 2.0-ready modules, and that we
firmly back them :-)


View raw message