Mailing-List: contact new-httpd-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
Date: Tue, 9 Jan 2001 08:36:55 -0800 (PST)
From: rbb@covalent.net
To: new-httpd@apache.org
Subject: RE: cvs commit: httpd-2.0/server/mpm/winnt mpm_winnt.c
In-Reply-To: <COEELENBBCHBFEPPGDOPAEOEDDAA.ake@meepzor.com>
Message-ID: <Pine.LNX.4.21.0101090833320.8047-100000@koj>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII


> I was mulling the same issue over yesterday. It seems to me that we
> _should_ be giving any specific match first shot. One way to do
> this is to specify AP_HOOK_LAST for any handlers that have wildcards.
> Question though, do we need to ensure foo/* get its shot before */* ?

A)  Specifying AP_HOOK_LAST won't work unless we separate the checks into
two functions, so that we have something like:

ap_hook_1(...)
{
    if(!strcmp(SPECIFIC, r->handler)
        real_handler
}

ap_hook_2(...)
{
    if (!strcmp_match(GENERAL, r->handler)
        real_handler
}

real_handler(...)
{
    ...
}

ap_hook_handler(ap_hook_1, NULL, NULL, AP_HOOK_MIDDLE)
ap_hook_handler(ap_hook_2, NULL, NULL, AP_HOOK_LAST)

While this will work, it is really bad, and I seriously dislike it, a lot.

b)  We never used to distinguish between foo/* and */* when ordering our
matches before, so we don't need to do it now.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------