Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 69078 invoked by uid 500); 24 Jan 2001 23:14:48 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 69043 invoked from network); 24 Jan 2001 23:14:44 -0000 X-Authentication-Warning: kurgan.lyra.org: gstein set sender to gstein@lyra.org using -f Date: Wed, 24 Jan 2001 15:15:27 -0800 From: Greg Stein To: new-httpd@apache.org Subject: Re: cvs commit: httpd-2.0/modules/http http_core.c http_protocol.c Message-ID: <20010124151527.L704@lyra.org> Mail-Followup-To: new-httpd@apache.org References: <20010124224758.24124.qmail@apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: ; from rbb@covalent.net on Wed, Jan 24, 2001 at 03:04:56PM -0800 X-URL: http://www.lyra.org/greg/ X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N On Wed, Jan 24, 2001 at 03:04:56PM -0800, rbb@covalent.net wrote: > On 24 Jan 2001 stoddard@apache.org wrote: > > > stoddard 01/01/24 14:47:58 > > > > Modified: modules/http http_core.c http_protocol.c > > Log: > > Remove the COALESCE_FILTER. It is no longer needed since Greg committed his ap_r* > > buffering patch. > > Um, I would rather you didn't do this. Greg's patch fixed the core, but > it doesn't solve the problem for other filters. Covalent is working on > code that generates a lot of small buckets. Without the coalesce filter > in the core, we am forced to put it in our module. I believe other > modules will have this same problem. I might tend to agree with Ryan on this one. The coalesce filter still has a purpose, but just not as obvious any more. We may want to avoid inserting it by default, and just have people request it explicitly if/when they are going to generate a lot of little buckets. [ and/or add a brigade-write system to avoid little buckets ] Cheers, -g -- Greg Stein, http://www.lyra.org/