Mailing-List: contact new-httpd-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
Date: Wed, 10 Jan 2001 14:40:35 -0800
From: Greg Stein <gstein@lyra.org>
To: new-httpd@apache.org
Subject: Re: woah, "GET /" with autoindex
Message-ID: <20010110144035.Z4640@lyra.org>
Mail-Followup-To: new-httpd@apache.org
References: <Pine.LNX.4.21.0101071329540.17843-100000@koj>
 <3A5CD267.373D368A@raleigh.ibm.com>
 <14940.57658.505323.664523@critterling.garfield.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <14940.57658.505323.664523@critterling.garfield.home>;
 from v.j.orlikowski@gte.net on Wed, Jan 10, 2001 at 05:24:58PM -0500

This kind of solution won't work. If you end up mixing ap_r* with bucket
calls, then you're screwed. The bucket would hit the chain before the
contents of the coalesce buffer.

And note that it would be quite easy for the mixture to happen. Handler H
starts writing some content with ap_r*(). Then, it calls ap_cool_utility(r)
which dumps some content via buckets. Oops!

The answer is to optimize ap_r* to not require so much allocation. It might
also be a good idea to insert a COALESCE filter IFF ap_r* gets called (e.g.
insert the filter on the first ap_r* call).

There was a question about whether other modules use ap_r* for lots of bits.
Absolutely... mod_dav is a simple example. PHP uses ap_r*, too.

Cheers,
-g

On Wed, Jan 10, 2001 at 05:24:58PM -0500, Victor J. Orlikowski wrote:
> (*blink blink*)
> Huh?
> (victor scrounges around. darn - not on his backup cd's...maybe in
> new-httpd archives - yes....)
> 
> Sorry - re-packaging old source from another project rots the brain.
> 
> This patch was only a preliminary idea, and showed slightly better
> performance, but it is still up for improvement. I've updated it to
> work against the current build tree.
>...

-- 
Greg Stein, http://www.lyra.org/