httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <>
Subject Re: [PATCH] allocate properly-sized buffer for header
Date Thu, 25 Jan 2001 17:36:49 GMT writes:

> This looks okay, but it is a very fragile solution.  The real problem
> IMHO, is that the bucket API is wrong.  This is just another symptom of
> the small bucket problem.  I think having to check for the length of the
> headers is a bad idea, because it will slow us down every time.  What we
> really want, is the same solution for the coalesce filter, namely the
> apr_brigade_* stuff, in whatever form it takes.
> What the ap_r* patch did was fix a symtpom, it didn't cure the disease.  
> This is another symptom.

I'm not sure I agree with your big picture*, but apr_brigade_* stuff
would definitely be a big improvement for this code.  Heck, ap_r* or
even ap_b* would be a big improvement for this code :)

*I'm extremely uncomfortable with the idea that a buffered API has no
way to get rid of the data -- e.g., ap_pass_brigade() -- before
returning to the caller.
Jeff Trawick | | PGP public key at web site:
             Born in Roswell... married an alien...

View raw message