httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <trawi...@bellsouth.net>
Subject Re: cvs commit: httpd-2.0/server util.c
Date Mon, 08 Jan 2001 18:15:28 GMT
"David Reid" <dreid@jetnet.co.uk> writes:

> I had done a cvs update just prior to the build and I was a bit surprised as
> I knew you were committing a fix...
> 
> david
> 
> > dreid@apache.org writes:
> >
> > > dreid       01/01/04 13:53:29
> > >
> > >   Modified:    server   util.c
> > >   Log:
> > >   This stops a segfault on my machine where I haven't got a hostname for
> > >   the function to find.
> >
> > If the new code is more correct then that is cool, but the segfault
> > should have gone away a few hours ago with a change to explicitly set
> > up the apr_file_t used to log to stderr.
> >
> 
> 
> 

FYI...  With this patch I can get the message on the terminal with no
segfault... 

(This is just to verify that we shouldn't expect to keep running into
this problem now.)

Index: server/util.c
===================================================================
RCS file: /home/cvspublic/httpd-2.0/server/util.c,v
retrieving revision 1.89
diff -u -r1.89 util.c
--- server/util.c       2001/01/05 20:44:44     1.89
+++ server/util.c       2001/01/08 18:18:24
@@ -1875,7 +1875,7 @@
     if (gethostname(str, sizeof(str) - 1) != 0)
 #endif
     {
-        ap_log_perror(APLOG_MARK, APLOG_STARTUP | APLOG_WARNING, 0, a,
+        ap_log_error(APLOG_MARK, APLOG_STARTUP | APLOG_WARNING, 0, NULL,
                      "%s: gethostname() failed to determine ServerName",
                      ap_server_argv0);
     }
@@ -1900,7 +1900,7 @@
     if (!server_hostname) 
         server_hostname = apr_pstrdup(a, "127.0.0.1");
 
-    ap_log_perror(APLOG_MARK,
     APLOG_ALERT|APLOG_NOERRNO|APLOG_STARTUP, 0, a,
+    ap_log_error(APLOG_MARK, APLOG_ALERT|APLOG_NOERRNO|APLOG_STARTUP,
     0, NULL,
                  "%s: Could not determine the server's fully qualified "
                  "domain name, using %s for ServerName",
                  ap_server_argv0, server_hostname);


-- 
Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message