httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <trawi...@bellsouth.net>
Subject Re: cvs commit: httpd-2.0/server/mpm/prefork prefork.c
Date Tue, 09 Jan 2001 05:04:10 GMT
Greg Stein <gstein@lyra.org> writes:

> On Tue, Jan 09, 2001 at 04:40:22AM -0000, trawick@apache.org wrote:
> >...
> >   --- scoreboard.c	2000/12/02 07:08:08	1.23
> >   +++ scoreboard.c	2001/01/09 04:40:21	1.24
> >   @@ -99,20 +99,23 @@
> >...
> >        ap_scoreboard_image = apr_shm_malloc(scoreboard_shm, SCOREBOARD_SIZE);
> >        if (ap_scoreboard_image == NULL) {
> >            apr_snprintf(buf, sizeof(buf), "%s: cannot allocate scoreboard",
> >                        ap_server_argv0);
> >   -        perror(buf);
> >   +        perror(buf); /* o.k. since MM sets errno */
> 
> We should be wrapping MM better than this. Callers use APR to allocate
> shared memory, and they should expect to use apr_status_t values.

yessir; really ugly as it is

-- 
Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message