httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <>
Subject Re: [PATCH] updated ap_r* patch
Date Mon, 22 Jan 2001 19:59:48 GMT
Greg Stein <> writes:

> Attached is an updated version of my patch to fix ap_r* performance.

in ap_rputs(), I don't see why we need to check for *str == '\0'...
this is a rare occurence and is checked for again in buffer_output()

in buffer_output...  can you use the core's module config for this
request where you say "record some flags in the request_rec..." ?

ap_r* functions are not consistent on reporting a buffer_output()

e.g., ap_rputs() needs something like

  if (buffer_output() == APR_SUCCESS) {
    return len;
    return -1;

Jeff Trawick | | PGP public key at web site:
             Born in Roswell... married an alien...

View raw message