httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: [PATCH] ap_fwrite, ap_fputs
Date Thu, 25 Jan 2001 23:20:53 GMT
> >+
> >+    /* Okay, so this sucks, but we don't have many options.  What we
> >+     * are doing here is just checking to see if we just converted 
> >the
> >+     * buffer into a new bucket and put it at the end of the 
> >brigade.  If
> >+     * we did, we want to pass the brigade to the next filter.  If 
> >not,
> >+     * we just keep going.  This allows us to use the network to 
> >limit how
> >+     * much data we send at any one time.
> >+     */
> >+    if (b != APR_BRIGADE_LAST(bb)) {
> >+        ap_pass_brigade(f->next, bb);
> >+    }
> 
> Why not build this test into the status code, or into another 
> parameter?  The apr_brigade_* functions know when the buffer was 
> converted into a bucket, so why not let them tell you?

Too much information to pass back.  I actually tried that at one point,
and couldn't find a way to do it that I really liked.  In reality, this
test is relatively clean.

I may take another stab at getting the check function to report if it
flushed the brigade or not, but not right away.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message