httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: Both ap_r* patches.
Date Sun, 21 Jan 2001 20:09:48 GMT
On Sun, 21 Jan 2001 rbb@covalent.net wrote:

> 
> > patch below fixes for me, is this the right thing todo?
> 
> Yep.
> 
> Ryan

BTW, the other option is to change all handlers to use r->bb for their
bucket brigade, whether they use ap_r* or not.  Either is perfectly valid,
this patch is MUCH safer however.

Ryan

> 
> > 
> > --- modules/http/http_protocol.c~	Sun Jan 21 10:39:42 2001
> > +++ modules/http/http_protocol.c	Sun Jan 21 11:16:03 2001
> > @@ -1621,7 +1621,13 @@
> >  {
> >      apr_bucket *b;
> >  
> > -    apr_brigade_flush(r->bb);
> > +    if (r->bb) {
> > +        apr_brigade_flush(r->bb);
> > +    }
> > +    else {
> > +        r->bb = apr_brigade_create(r->pool);
> > +    }
> > +
> >      b = apr_bucket_create_eos();
> >      APR_BRIGADE_INSERT_TAIL(r->bb, b);
> >      ap_pass_brigade(r->output_filters, r->bb);
> > 
> > 
> 
> 
> _______________________________________________________________________________
> Ryan Bloom                        	rbb@apache.org
> 406 29th St.
> San Francisco, CA 94131
> -------------------------------------------------------------------------------
> 
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message