httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: [PATCH] ap_r* performance patch
Date Fri, 19 Jan 2001 03:35:16 GMT

A few comments before I review in great detail.  The actual numbers (2 vs
3.5) can't be compared here.  I used a 4K buffer while you used a 9KK
buffer.  That means I always had one more allocation than you do.  Not a
big deal, but it is there.

This only solves the Apache problem, which doesn't solve the main problem
that Dean pointed out, namely that the brigades don't buffer.  You have
put buffering into the core.

Item 5 is easy to get with the other patch, I used palloc, because I
wanted to avoid the malloc/free whenever possible.

More detailed review later.

Ryan

> 1) 3.5x speedup in requests/sec and thruput on my box
> 2) strace shows a single writev and hugely improved alloc behavior
> 3) mixed-style output is possible
> 4) network congestion is used
> 5) memory is NOT proportional to output size: it mallocs/frees at each
>    network delivery
> 6) ap_r* API is unchanged
> 
> Yesterday, Ryan posted a list of five "priorities", which are all met by the
> above list of benefits.
> 
> Cheers,
> -g
> 
> -- 
> Greg Stein, http://www.lyra.org/
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message