httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: [PATCH] bucket problems.
Date Wed, 17 Jan 2001 21:15:57 GMT

> Well, it is hard to distinguish what you are intended to be an *example*
> versus the *real* solution.
> 
> "Here's what I'm thinking" seems to imply just that -- where you think the
> code needs to go for the long term.
> 
> The changes to mod_autoindex are badness.

No, one change to mod_autoindex is badness.  We need to actually call
ap_pass_brigade when it makes sense.  The rest of the changes are fine.

> 1) overall performance?
> 2) speeding up ap_r*
> 3) reducing the number of traversals down the chain
> 4) fixing sub-optimal network packet behavior
> 5) too many chunks in the output
> 6) ...
> 
> What is the problem being solved by this patch? "here is another API; do you
> see how modules can use it to do output?"

The specific problem is that ap_r* functions suck right now.  They are
completely horrible because we have to create a single bucket for each
call to ap_r*.  Also, when we have so many small buckets, our
core_output_filter ends up creating a bunch of iovec's that have 16
elements, and are very small.  We need to actually buffer data into a
single buffer, and we should do this without creating the individual
buckets.

> I feel that if we have a better handle on the specific issue, then we can
> concentrate on that one better. While it may have been stated before, and I
> could have missed it, it really isn't clear right now.
> [ Dean had a number of issues with the performance, but I'm not sure which
>   one we're specifically solving ]

My patch solves the problems mentioned above.  I am not currently aware of
any other problems brought up by Dean.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message