httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: woah, "GET /" with autoindex
Date Sun, 07 Jan 2001 21:30:54 GMT

> > > since the underlying ap_bucket_putstr and ap_bucket_printf are implemented
> > > as one-copy, coalesce will result in a two-copy implementation... which is
> > > less than 1.3's one-copy implementation.
> > >
> > > not to mention that the current ap_bucket_{putstr,printf} result in far
> > > too many ap_bucket_ts being allocated.
> >
> > But like I said, those functions aren't being used in this case.
> 
> ap_rprintf is essentially an ap_bucket_printf.  so it is being used.
> 
> ap_rputs does essentially what ap_bucket_putstr does... unless i'm totally
> misreading the code.  ap_rputs creates a transient bucket which is a
> one-copy.  ap_bucket_putstr creates a heap bucket... with copy.

They are close, but they aren't exactly the same.  If module is using the
ap_r* functions, then we can assume that it isn't using the buckets
directly, and we can buffer.  If a module is using the buckets directly,
then where do we put the buffer?

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message