httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: httpd-2.0/server/mpm/prefork prefork.c
Date Sun, 07 Jan 2001 20:49:46 GMT

>    #define ASIS_MAGIC_TYPE "httpd/send-as-is"
>    
>   -static int asis_handler(request_rec *r)
>   +static int asis_handler(const char *handler,request_rec *r)
>    {
>        apr_file_t *f = NULL;
>        apr_status_t status;
>        const char *location;
>        apr_size_t nbytes;
>    
>   +    if(strcmp(handler,ASIS_MAGIC_TYPE) && strcmp(handler,"send-as-is"))
>   +	return DECLINED;

Can we change the strcmp to a memcmp, since we know that these are static
strings?

>   @@ -1543,7 +1543,6 @@
>        static int restart_num = 0;
>        int no_detach = 0;
>    
>   -    one_process = !!getenv("ONE_PROCESS");
>        no_detach = !!getenv("NO_DETACH");
>    
>        /* sigh, want this only the second time around */
>   @@ -1578,7 +1577,7 @@
>    #ifdef AUX3
>        (void) set42sig();
>    #endif
>   -    /* TODO: set one_process properly */ one_process = 0;
>   +    one_process = !!getenv("ONE_PROCESS");

Why was this moved?  It worked properly on Linux, and by removing the 
one_process=0, it worked on FreeBSD as well.  Just asking, because we
probably want to move the no_detach to the same location.  The basically
do the same thing.

Ryan
_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message