httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Marr <gr...@alum.wpi.edu>
Subject Re: [PATCH] ap_fwrite, ap_fputs
Date Thu, 25 Jan 2001 22:36:34 GMT
At 04:42 PM 01/25/2001, rbb@covalent.net wrote:
>+    status = apr_brigade_write(bb, str, nbyte);
>+
>+    /* Okay, so this sucks, but we don't have many options.  What we
>+     * are doing here is just checking to see if we just converted 
>the
>+     * buffer into a new bucket and put it at the end of the 
>brigade.  If
>+     * we did, we want to pass the brigade to the next filter.  If 
>not,
>+     * we just keep going.  This allows us to use the network to 
>limit how
>+     * much data we send at any one time.
>+     */
>+    if (b != APR_BRIGADE_LAST(bb)) {
>+        ap_pass_brigade(f->next, bb);
>+    }

Why not build this test into the status code, or into another 
parameter?  The apr_brigade_* functions know when the buffer was 
converted into a bucket, so why not let them tell you?

-- 
Greg Marr
gregm@alum.wpi.edu
"We thought you were dead."
"I was, but I'm better now." - Sheridan, "The Summoning"


Mime
View raw message