httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Ames <>
Subject Re: [PATCH] allocate properly-sized buffer for header
Date Fri, 26 Jan 2001 14:24:53 GMT
Greg Ames wrote:
> >
> > When used by ap_http_header_filter(), other stuff has to happen
> > between step 1 and step 2, and Ryan and Greg found out recently.
> >
> > A simple solution is to split the function in two parts and change any
> > caller of the old function to call the two functions instead.
> Will this patch take care of our header leakage/duplication/overwrite
> problem?  If so, can we commit it ASAP, then move on to more elegant solutions? 

OK - this patch fixes the header ugliness that I saw on
.  I will test it more on my own box, then I plan to commit it unless
someone comes up with a better *working* alternative very quickly.  I
think this will make Martin and Peter Moore much happier as well.

I'm still seeing broken .gifs, but that feels like a different issue.


View raw message