httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Ames <grega...@raleigh.ibm.com>
Subject Re: [PATCH] bucket problems.
Date Wed, 17 Jan 2001 19:13:57 GMT
TOKILEY@aol.com wrote:
> 
> In a message dated 01-01-17 09:33:53 EST, Ryan writes...
> 
> >  This patch addresses Dean's problems with the bucket code.
> ...
> >  Please review ASAP, I would like to commit VERY quickly.
> 
> Yikes.
> 

> 
> It is the ap_rXXXX() API calls themselves that can
> simply 'know what to do' so legacy modules don't have
> to suffer this kind of total rewrite.
> 
> Couldn't you just keep mod_autoindex exactly the way
> it is and simply do this...
> 
> 1. Add a 'default brigade' pointer to the request
> record itself. Make sure it's NULL on request init.
> Might get used, might not.
> 

I agree, except that IMO the "default brigade" pointer will ultimately
end up in the conn_rec, so we can send the optimal number of packets for
pipelined/keepalive scenarios, which means we need a longer lifetime
than the request_rec.  If you buy that, let's do it correctly this time
around.

Greg

Mime
View raw message