httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: windows build & handler hook
Date Tue, 09 Jan 2001 09:30:00 GMT
Greg Stein wrote:
> 
> On Mon, Jan 08, 2001 at 10:37:40PM +0000, Ben Laurie wrote:
> > rbb@covalent.net wrote:
> > >
> > > It looks like the API is going to change again soon to stop passing the
> > > handler char * into the function.  Instead we would be using the
> > > r->handler field.
> >
> > You can't step on that field without possibly unforeseen consequences.
> > Or maybe you can :-)
> >
> > Anyway, the defacto meaning for that field is that it is set by
> > {Add,Set}Handler, so setting it for this may be a mistake. I'm +1 on a
> > reasoned argument that says its OK to do this, or, failing that, a new
> > field.
> 
> Modules can also set r->handler as appropriate. For example, mod_dav sets it
> in the "type check" phase. mod_actions sets it based on various criteria.
> 
> All of them are about getting the correct handler into r->handler. I see
> nothing wrong with modules setting that value when appropriate.

I agree with that - my concern was setting it in a new place, for a new
purpose. However, as Doug points out, it only gets set when its NULL, so
I guess its OK.

Cheers,

Ben.

--
http://www.apache-ssl.org/ben.html

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff

Mime
View raw message