httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: index.html not served w/mod_autoindex active
Date Sun, 07 Jan 2001 21:54:03 GMT
Jon Travis wrote:
> > >  You are doing it
> > > everytime in ap_invoke_handler anyway, so the only inneficiency is that
> > > introduced is an extra function call.
> >
> > What?
> 
> You said that "Because then it has to be done every time, which is inneficient"
> referring to the work that is done in ap_invoke_handler.

No, I meant if you do it in the hook, you do it in every module.

> > >  And if you wanted, you could add
> > > another field to the request_rec, and just manipulate that within
> > > your ap_invoke_handler routine, or whatever.   That would save the
> > > overhead of the function call.
> >
> > I could by that. Makes it less clear how you get from A to B, but I'm
> > not that fussed. OTOH, request_rec _already_ has handler:
> >
> >     /** The handler string that we use to call a handler function */
> >     const char *handler;      /* What we *really* dispatch on           */
> >
> > the comments are a complete lie, of course. I don't know whether we can
> > fix them without breaking stuff.
> 
> I don't know that adding the overhead of an extra function call is that
> major of a deal here.  Some may disagree.  It is certainly more clear then
> adding more stuff to the request_rec, IMO.

Even more clear is passing it in the function call. :-)

Cheers,

Ben.

--
http://www.apache-ssl.org/ben.html

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff

Mime
View raw message