httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: cvs commit: apache-1.3/src/modules/standard mod_userdir.c
Date Thu, 25 Jan 2001 23:50:30 GMT
William A. Rowe, Jr. wrote:
> 
> I've been inside and outside of this patch, and something has me -very-
> concerned.
> 
> 
> This is -effectively- the very same test as before.  NOW the problem.  I _really_
> believe the original author ment to test ap_os_is_path_absolute(), but -NOT-
> of the parsed userdir, but the source userdir!
> 
> If anyone out there believes me strongly enough to agree, please comment out the
> #ifdef exclusion of unix above, and change the (userdir[0] == '/') test to 
> for (is_absolute) instead, and we can all sleep well tonight.
> 

How about if I contact Brad (the orig author, IIRC) and check with
him first... trying to 2nd guess someone's "real" intent makes
me sleepless :)

-- 
===========================================================================
   Jim Jagielski   [|]   jim@jaguNET.com   [|]   http://www.jaguNET.com/
          "Casanova will have many weapons; To beat him you will
              have to have more than forks and flatulence."

Mime
View raw message