httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <>
Subject Re: [PATCH] allocate properly-sized buffer for header
Date Thu, 25 Jan 2001 18:40:05 GMT
On Thu, Jan 25, 2001 at 10:10:06AM -0800, wrote:
> > *I'm extremely uncomfortable with the idea that a buffered API has no
> > way to get rid of the data -- e.g., ap_pass_brigade() -- before
> > returning to the caller.

Ah. Excellent way to phrase it. Yes, this was the key issue that I
discovered with the buffered API at the brigade level, rather than up at the
ap_r* level. It had to copy everything before returning -- it had no way to
save it otherwise, and it had nowhere to send it.

> It would be possible to create ap_f* functions with the apr_brigade_*
> functions, which would buffer and still provide the ap_pass_brigade call
> before returning to the caller.  This would also allow filter writers to
> avoid dealing with brigades directly.  I'll work up a REALLY quick patch
> that shows the ideas without being perfectly correct.

Hmm. I presume you're thinking of passing a "flush function" down to the
apr_brigade_* functions? That just might work.

Looking forward to your half-patch :-)


Greg Stein,

View raw message