httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: [PATCH] checking arguments in configure
Date Wed, 24 Jan 2001 23:42:08 GMT
--with-optim should just be punted. It is a non-standard switch to
configure. Typically, people will pass this via CFLAGS. I've also seen the
use of OPT, such as:

$ OPT= ./configure      # disable default optimization
$ OPT=-O9 ./configure   # turn it up

The switch is funky, so I'd be +1 on removing it entirely (and relying on
CFLAGS or OPT).

Cheers,
-g

On Wed, Jan 24, 2001 at 11:18:27PM -0000, David Reid wrote:
> Should probably be determine by platform if we do as some optimisations
> aren't for some platforms, if that makes sense...  It could be added as a
> default (O2) overridable by hints.m4?
> 
> david
> 
> ----- Original Message -----
> From: "Roy T. Fielding" <fielding@ebuilt.com>
> To: <new-httpd@apache.org>
> Sent: Wednesday, January 24, 2001 8:16 PM
> Subject: [PATCH] checking arguments in configure
> 
> 
> > This bit me last night.  My question is, should we default to -O
> > for this option, or require that a flag be given (as below)?
> >
> > ....Roy
> >
> > Index: configure.in
> > ===================================================================
> > RCS file: /home/cvs/httpd-2.0/configure.in,v
> > retrieving revision 1.115
> > diff -u -r1.115 configure.in
> > --- configure.in 2001/01/10 01:04:52 1.115
> > +++ configure.in 2001/01/24 23:11:52
> > @@ -112,7 +112,7 @@
> >  AC_CHECK_LIB(socket, socket)
> >
> >  AC_ARG_WITH(optim,[  --with-optim="FLAGS"      compiler optimisation
> flags],
> > -        [OPTIM="$withval"])
> > +        [if test "$withval" = "yes"; then
> AC_MSG_ERROR('option --with-optim requires a value (the optimisation
> flags)'); else OPTIM="$withval"; fi])
> >
> >  AC_ARG_WITH(port,[  --with-port=PORT        Port on which to listen
> (default is 80)],
> >          [PORT="$withval"],
> >

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message