httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <>
Subject Re: [PATCH] ap_r* performance patch
Date Fri, 19 Jan 2001 03:57:48 GMT
On Thu, Jan 18, 2001 at 07:53:08PM -0800, wrote:
> I am actually about to run a test on your patch, my patch, and the current
> 2.0.  Along with that, I will be generating strace's, and comparing them.

Kick ass.

> > I hope the post explains it well enough, but just ask if something is
> > unclear.
> This is definately very different from what I had envisioned given your
> explanation.

I started down a path of reusing a bucket, but realized that our design
simply doesn't allow that. apr_bucket_destroy() will free() the bucket --
you can't do anything about it. The destroy() bucket-type function is only
for the per-bucket data. So... that blew away the thought of reusing a
brigade and bucket for transmitting data into the buffering filter. But I
found a better way :-)

[ we could probably still reuse brigades in many places ]

The outline I posted does correspond to the new pattern, but the stuff I
was talking about yesterday/today would only work to a point (the filter is
the same, the only diff is how you get data into it).

> I really need to spend a lot more time looking at it, but
> that will have to come later tonight.  :-)

Not a problem. There isn't a rush on this stuff right now. I've got a big
patch from John Vasta (against mod_dav) to review and check in.


Greg Stein,

View raw message