httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: [PATCH] bucket problems.
Date Wed, 17 Jan 2001 21:41:45 GMT
On Wed, Jan 17, 2001 at 01:33:52PM -0800, rbb@covalent.net wrote:
> 
> > > Also, even if I agreed that we should keep a copy of the brigade in an
> > > Apache strucure, which I don't, the conn_rec is the wrong place for
> > > it.  This brigade is only used for the handler, and by definition that is
> > > a request level thing.
> > 
> > Why not hang the brigade off the conn_rec?  When you first create it, it has a
> > buffer associated with it and that's all (no filters, etc.). Use it for a
> > request then clean it out when you are done to prepare it for the next
> > request.  A brigade has a lifetime that is equal to or longer than the
> > buckets/filters in the brigade
> 
> Huh?  A brigade never has any filters associated with it.  The brigade
> doesn't belong in the conn_rec.  In Apache 1.3, the BUFF was a static
> thing, it grew and that was it, so we put it in the conn_rec, and when
> data was put into it, it stayed there.  In Apache 2.0, a brigade is a very
> dynamic thing.  It changes constantly.  It doesn't make any sense to put a
> brigade in the conn_rec.

Yes, it makes sense. The brigade is the analogue to the BUFF structure in
the conn_rec. It holds data pending its transmission over the network.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message