httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jon Travis <jtra...@covalent.net>
Subject Re: index.html not served w/mod_autoindex active
Date Sun, 07 Jan 2001 22:03:56 GMT
On Sun, Jan 07, 2001 at 02:00:53PM -0800, Greg Stein wrote:
> On Sun, Jan 07, 2001 at 01:44:14PM -0800, Jon Travis wrote:
> > On Sun, Jan 07, 2001 at 09:39:29PM +0000, Ben Laurie wrote:
> >...
> > > I could by that. Makes it less clear how you get from A to B, but I'm
> > > not that fussed. OTOH, request_rec _already_ has handler:
> > > 
> > >     /** The handler string that we use to call a handler function */
> > >     const char *handler;	/* What we *really* dispatch on           */
> > > 
> > > the comments are a complete lie, of course. I don't know whether we can
> > > fix them without breaking stuff.
> > 
> > I don't know that adding the overhead of an extra function call is that
> > major of a deal here.  Some may disagree.  It is certainly more clear then
> > adding more stuff to the request_rec, IMO.
> 
> Slow down, Tex. Nobody has added anything to request_rec. The "handler"
> field has always been in there.
> 
> I'm lost on this thread. Step back, and re-present it with your thoughts.
> What exactly is the issue with the current organization?
> 
> Personally, I find calling N handler functions more expensive than the old
> mechanism. However, I do like the new registration-based system. I'd take it
> a bit further and have an explicit handler system in Apache where the
> modules register a handler->func mapping in an Apache-internal hash table.
> At runtime, we just go BAM! and yank out the func and call it.
> 
> Of course, that doesn't have the neato ordering that the hooks has
> introduced.
> 
> A possible optimization goes back to something Ryan did with some early hook
> patches: per-request hook registration. Each module would register their
> handler on the *request*, if they think they might apply to that request.
> Apache would then run them, in order. The typical list would be *much*
> shorter.

My beef is not that we are using hook based instead of running through
stuff defined in the module_rec.  I'm only concerned with the fact that
we have changed the prototype for the content generation functions.

-- Jon


Mime
View raw message