httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: [PATCH] - Userdir broken in Apache 1.3.16 for NetWare...
Date Thu, 25 Jan 2001 03:39:44 GMT
I thoroughly dislike using scattering ifdefs through the module like this.
May I ask... what is keeping us from correcting the ap_os_path_is_absolute
function to distinguish between SYS:/path and HTTP://path?

How doesn't C:/Foo look like http://foo?  Win32 handles this fine, so I
suspect we can do a more effective job with the mod_userdir.c patch.
I'd rather we give you 24 more hours to think that aspect through, and
solve the general case over the specific case, since a broken general
case usually implies bugs hidden that are yet to be discovered.

That said, I'll spend another half hour on this tonight, to see if I'm
missing something blatently obvious.

[I would condense your two CHANGES entries to one.  Consider that we
rely on cvs versioning to describe gory details, and CHANGES to communicate
the net effects to the end users.  You are always welcome to throw the
detailed, gory commit log message with your patch, along with the 'reader's
digest' version of the comments ;-]

Bill



From: "Brad Nicholes" <BNICHOLES@novell.com>
Sent: Wednesday, January 24, 2001 6:00 PM


Bill,
     It appears that the patch only cleaned up half of the problem.  I left out the part that
actually checks for an absolute path
in MOD_USERDIR.c.  I have attached the patch here for MOD_USERDIR.  We had the same problem
as WIN32.  Translate_Userdir() could not
tell the difference between an absolute path and a URL.  I retested the full patch and it
appears to have solved the problem.

thanks,
Brad

>>> wrowe@rowe-clan.net Wednesday, January 24, 2001 9:46:34 AM >>>
Brad,

  very nice patch ... affects only the Netware code path.  Note the first part
in http_main.c was nearly applied before (I notice you added the chdir after I
reviewed and applied that part of the patch some time ago.  Check it closely.)

  Please, though it won't break anyone else, please ack that you are able to
perform a clean checkout, build, and run (and if you report that the userdir
problem is gone, I'll close the two PR's with invitations to grab the forthcoming
1.3.17 version.)

Bill






Mime
View raw message