httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: cvs commit: apache-1.3/src/modules/standard mod_userdir.c
Date Thu, 25 Jan 2001 21:57:05 GMT
From: "Jim Jagielski" <jim@jaguNET.com>
Sent: Thursday, January 25, 2001 3:52 PM


> Being picky here, I admit :)
> 
> wrowe@apache.org wrote:
> >                if (x) {
> >    #ifdef NETWARE 
> >                    if (strchr(x, ':') && !is_absolute )
> >   -#else
> >   -#ifdef HAVE_DRIVE_LETTERS
> >   +#elif defined(HAVE_DRIVE_LETTERS)
> >                    /*
> >   @@ -296,7 +301,11 @@
> >            }
> >    #ifdef NETWARE
> >            else if (strchr(userdir, ':') && !is_absolute ) {
> >   -#else        
> >   +#elif defined(HAVE_DRIVE_LETTERS)
> >   +        /* Same Crummy hack here
> 
> If we're using #elif, I'd prefer #if defined(NETWARE)

pedantic is more the word :-)

I'll fix the ap_is_absolute_path snafu at the same time, if you like.


Mime
View raw message