httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: [PATCH - Showstopper] 1.3.17-dev mod_userdir
Date Thu, 25 Jan 2001 19:46:04 GMT
From: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
Sent: Thursday, January 25, 2001 12:10 PM
>
> The patch below -removes- this question from mod_userdir, were it never belonged, and
> elevates it to the ap_is_url() function.  That function, on colon delimited file systems
> (including Mac OS-pre-X) could do wonders for us.  Or it could break us entirely.

Now that I scared everyone... here's my analysis:

#src\include\ap_compat.h(184):#define is_url                         ap_is_url
#include\httpd.h(1008):API_EXPORT(int) ap_is_url(const char *u);
#main\util.c(1714):API_EXPORT(int) ap_is_url(const char *u)
#test\rename\apapi.h(125):extern int                  ap_is_url(const char *u);
#test\rename\apapi_compat.h(133):#define is_url                         ap_is_url
#test\rename\compat.h(170):#define is_url                         ap_is_url
#modules\standard\mod_userdir.c(275):                if (ap_is_url(x)) {
#modules\standard\mod_userdir.c(286):        else if (ap_is_url(userdir)) {

doh, these (with the patch) speak for themselves.

#main\http_core.c(1154):       ((ap_is_url(string) || (*string == '/')) && (*string
!= '"')) ? 
#main\http_request.c(1073):        if (ap_is_url(custom_response)) {

However you cut it, set_error_document() is goofy.  I'm researching further.
As I read it, only local redirects (absolute url form), external redirects and the
error string is supported.  Since this is never a real file path, we are fine here,
and the exsternal form is docmented as httpd://foo/, so nothing changes.

modules\standard\mod_alias.c(202): if (!use_regex && !ap_is_url(url))

You can't do a redirect to a mailto: or news: item if this patch is applied.
Is this an issue?  It seems everything we would redirect to is a scheme://
formatted resource.

That's the whole ball of wax.  Probability of a new bug is now at 1 to 10 ^ 4 and falling...



Mime
View raw message