httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <>
Subject Re: cvs commit: apache-1.3/src/modules/standard mod_userdir.c
Date Thu, 25 Jan 2001 21:54:20 GMT
> wrowe       01/01/25 13:22:28
>   Modified:    src      CHANGES
>                src/modules/standard mod_userdir.c
>   Log:
>     Fix one case of win32/os2 failing to accept a UserDir c:/userdir
>     argument, close a potential segfault, and accept backslashed UserDir
>     path if the admin wasn't paying attention.

This is now tested with the follow possibilities:

    UserDir "*"
    UserDir "d:\Documents and Settings\*\My Documents\My Website\"
    UserDir "C:/Apache/users/"

The form that would fail on 1.3.15 was

    UserDir "D:/Apache/*_web"

which, while uncommon, isn't inconcievable.  We have the wrong test, it's
simply misleading, here:

 if (userdir[0] == '\0' || ap_os_is_path_absolute(userdir)) {

which should simply be

 if (userdir[0] == '\0' || userdir[0] == '/')) {

which says the segment -following- the '*' is a folder, in url notation.

Again, a change for after 1.3.17, since the only way to be bitten (on win32)
would be for the administrator to configure:

  UserDir "D:/Apache/*d:/"

which is senseless anyways.


View raw message