httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <trawi...@bellsouth.net>
Subject Re: cvs commit: apache-2.0/src/modules/mpm/prefork prefork.c
Date Fri, 01 Dec 2000 18:06:36 GMT
rbb@covalent.net writes:

> >   If apr_lock() or apr_unlock() fail, write a log message before bailing
> >   out.
> 
> Woah.  You just took a debug only check, and turned it into a run-time
> check that happens every time.  I'm not saying this is bad, but it should
> be noted in the log.  :-)

ap_assert() is a run-time check...  I don't see the performance
change (okay, our code is a tiny bit bigger which hurts cache/VM)

-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...

Mime
View raw message