httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: style giude, was Re: [PATCH] rotatelogs fix .. update
Date Sun, 03 Dec 2000 22:24:59 GMT
Brian Havard wrote:
> 
> On Thu, 16 Nov 2000 22:32:04 -0600, William A. Rowe, Jr. wrote:
> 
> >> From: Tony Finch [mailto:dot@dotat.at]
> >> Sent: Thursday, November 16, 2000 9:53 PM
> >>
> >> I intend to commit this.
> >
> >Undoubtedly - but not without a vote here - this has been argued
> >to death in the past and for mostly good reasons.  I'm -.5 for this
> >change, tabified code tends to get brutalized - especially when
> >we need mass edits.  Further, your definition is wrong, tab advances
> >the column to 8 + (cur column mod 8), not 8 spaces, as you worded it.
> 
> Agreed, the style guide shouldn't be changed without a vote and I'm -1
> (vote not veto) on this change.

To drag up an old issue ... I'm +1 on this: it documents a fact of life.

Cheers,

Ben.

> 
> >> Index: styleguide.html
> >> ===================================================================
> >> RCS file: /home/cvs/apache-devsite/styleguide.html,v
> >> retrieving revision 1.7
> >> diff -u -r1.7 styleguide.html
> >> --- styleguide.html  1998/04/20 05:32:47     1.7
> >> +++ styleguide.html  2000/11/17 03:48:04
> >> @@ -31,8 +31,8 @@
> >>      following line at the start of a function definition.
> >>     </LI>
> >>     <LI>Code inside a block (whether surrounded by braces or not) is
> >> -    indented by four space characters. Tab characters are not
> >> -    used. Comments are indented to the same level as the surrounding
> >> +    indented by four space characters. Tab characters are
> >> equivalent to
> >> +    eight spaces. Comments are indented to the same level as
> >> the surrounding
> >>      code.
> >>     </LI>
> >>     <LI>Closing braces are always on a separate line from surrounding
> 
> --
>  ______________________________________________________________________________
>  |  Brian Havard                 |  "He is not the messiah!                   |
>  |  brianh@kheldar.apana.org.au  |  He's a very naughty boy!" - Life of Brian |
>  ------------------------------------------------------------------------------

--
http://www.apache-ssl.org/ben.html

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff

Mime
View raw message