httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Pool <...@linuxcare.com.au>
Subject Re: [PATCH] Re: mod_log_config: Cookie logging patch 1.3.X
Date Thu, 14 Dec 2000 03:13:27 GMT
> The parsing used in that patch works and is pretty similar to code
> used in mod_usertrack as you pointed out. 
> 
> The code is fine, but if we want to modularize it and create something 
> similar to ap_get_token then thats fine with me also.

Well, I would suggest that actually it does not work properly.  If the
cookie name is 'a' and there happens to be an 'a' character earlier in
the header, then I'm pretty sure that routine will return a bogus
result.  It doesn't check that the match is actually a complete cookie
name.  So you can either fix it now, or wait for somebody to encounter
the problem and submit it as a bug.

-- 
Martin Pool, Linuxcare, Inc.
+61 2 6262 8990
mbp@linuxcare.com, http://www.linuxcare.com/
Linuxcare. Support for the revolution.

Mime
View raw message