httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Pool <>
Subject Re: [PATCH] Re: mod_log_config: Cookie logging patch 1.3.X
Date Thu, 07 Dec 2000 23:38:28 GMT
On  7 Dec 2000, Greg Stein <> wrote:

> -1 (veto) on the ap_get_token() changes. The modified code stops on
> characters other than "," and ";" (change of behavior).

That's very true -- sorry.  The mod_negotiation code requires that
this function actually *not* retrieve tokens, according to the RFC
grammar for "token".  Specifically "text/html" is two tokens with a
slash in between, but mod_negotiation thinks it is just one.

> -0 on this patch

If I put ap_get_token back to the old behaviour, add a new function to
really read tokens, and patch the ap_get_token documentation will that
be OK?  Or do you not want to add this feature in 1.3?

Martin Pool, Linuxcare, Inc.
+61 2 6262 8990,
Linuxcare. Support for the revolution.

View raw message