httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jon Travis <jtra...@covalent.net>
Subject Re: [PATCH] inet_ntoa thread safeness cleanup
Date Sat, 02 Dec 2000 03:40:59 GMT
On Fri, Dec 01, 2000 at 08:31:26PM -0500, Jeff Trawick wrote:
> Jon Travis <jtravis@covalent.net> writes:
> 
> > inet_ntoa is generally not threadsafe.  This patch cleans up a few files
> > which use it.  It is worth noting that the proxy module uses inet_ntoa all
> > over the place, but since this is in a big rehashment right now, I didn't
> > touch it.  I imagine a lot of this will become obsolete as we get more
> > IPV6 friendly, but this fixes it for now.
> 
> It is my desire that an APR app would ordinarily have no business
> messing with apr_inet_ntop() and apr_inet_pton().  That is why the
> prototypes are in private header files instead of apr_network_io.h.
> 
> Just the act of choosing the first parameter to either of these
> functions is a detail best left to APR whenever possible.
> 
> Whether or not Apache core and modules will be free of this type of
> logic remains to be seen :)  For now, I hope that when the code you
> patched is cleaned up soon for IPv6 we will be able to rely on APR to
> build a presentable form of the IP address with no need to be
> concerned with the appropriate address family.

Sounds good to me.  I'm only concerned with the thread safety of Apache. 
It would indeed be cool to have family information in the in_addr structures
or however you decide to go about doing this.  

-- Jon


Mime
View raw message