httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-2.0/src/support httpd.exp
Date Sat, 02 Dec 2000 00:48:07 GMT
On Fri, Dec 01, 2000 at 05:06:03PM -0500, Jeff Trawick wrote:
> Greg Stein <gstein@lyra.org> writes:
> > I presume the next step will be to make ap_new_connection() take an
> > apr_sockaddr_t rather than a sockaddr_in ?
> 
> The next step I chose was to get rid of those parms altogether... 
> ap_new_connection() has the apr_socket_t so it has all it needs.  We
> don't need ap_new_apr_connection() anymore as I recall.

Simplification! Woo! :-)

> Unfortunately, after getting the normal code working I went into the
> WinNT MPM ('cause it too calls ap_new_connection()) and realized I
> needed to do some research about whether or not the APR socket (built
> via apr_put_os_sock()) is properly initialized on Windows.

We should probably toss the apr_put_os_* functions and call them something
like apr_os_make_*() and accept the particular OS object to construct the
APR type.

>...
> Is this a long enough answer?

Yes :-)

Thx!
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message