httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-2.0/src/support httpd.exp
Date Fri, 01 Dec 2000 21:45:13 GMT
On Fri, Dec 01, 2000 at 06:49:54PM -0000, trawick@locus.apache.org wrote:
> trawick     00/12/01 10:49:52
> 
>   Modified:    src/main http_connection.c
>                src/support httpd.exp
>   Log:
>   Stop referencing apr_get_socket_inaddr(), apr_get_remote_name(), and
>   apr_get_local_name().  They have been removed.
>...
>   --- http_connection.c	2000/11/21 19:10:16	1.63
>   +++ http_connection.c	2000/12/01 18:49:51	1.64
>   @@ -303,9 +303,10 @@
>    conn_rec *ap_new_apr_connection(apr_pool_t *p, server_rec *server, 
>                                    apr_socket_t *conn_socket, long id)
>    {
>   -    struct sockaddr_in *sa_local, *sa_remote;
>   +    apr_sockaddr_t *sa_local, *sa_remote;
>    
>   -    apr_get_local_name(&sa_local, conn_socket);
>   -    apr_get_remote_name(&sa_remote, conn_socket);
>   -    return ap_new_connection(p, server, conn_socket, sa_remote, sa_local, id);
>   +    apr_get_sockaddr(&sa_local, APR_LOCAL, conn_socket);
>   +    apr_get_sockaddr(&sa_remote, APR_REMOTE, conn_socket);
>   +    return ap_new_connection(p, server, conn_socket, 
>   +                             &sa_remote->sa.sin, &sa_local->sa.sin,
id);
>    }

I presume the next step will be to make ap_new_connection() take an
apr_sockaddr_t rather than a sockaddr_in ?

These changes look good. Definitely a positive step towards IPv4/IPv6
independence!

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message