httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject RE: PR 6973 / 1.3.15 showstopper
Date Fri, 15 Dec 2000 15:25:01 GMT
> From: Jim Jagielski [mailto:jim@jaguNET.com]
> Sent: Friday, December 15, 2000 9:00 AM
> 
> Yep, you're right. 
> 
> I think it's that final return statement... Should be:
> 
>     (*start >= 0 || *end <= clength - 1)

Nope ... *end >= clength needs to set *end = clength - 1 per the RFC.
That's not true of *start >= clength, though.  That's why I gave up
and proposed the alternate patch... I needed to explicitly see every
case.  Tony's right ... it isn't worth implementing 416, but that
doesn't mean we don't get the tests right.
 
> I *think* all the above tests ensure that's OK...
> 
> William A. Rowe, Jr. wrote:
> > 
> > Nak... it doesn't catch legitimate requests for -1.
> > 
> > if (*start > *end) already catches -0, --1 etc.
> > 
> > > -----Original Message-----
> > > From: Jim Jagielski [mailto:jim@jaguNET.com]
> > > Sent: Friday, December 15, 2000 8:17 AM
> > > To: new-httpd@apache.org
> > > Subject: PR 6973 / 1.3.15 showstopper
> > > 
> > > 
> > > Seems to me that Tony's patch is in the right direction. 
> I think the
> > > 
> > >  if (*start == *end)
> > >    return 0;
> > > 
> > > block should be inserted in line 164 though.
> > > 
> > > -- 
> > > ==============================================================
> > > =============
> > >    Jim Jagielski   [|]   jim@jaguNET.com   [|]   
> > > http://www.jaguNET.com/
> > >           "Casanova will have many weapons; To beat him you will
> > >               have to have more than forks and flatulence."
> > > 
> > 
> 
> 
> -- 
> ==============================================================
> =============
>    Jim Jagielski   [|]   jim@jaguNET.com   [|]   
http://www.jaguNET.com/
          "Casanova will have many weapons; To beat him you will
              have to have more than forks and flatulence."


Mime
View raw message