httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <>
Subject RE: cvs commit: apache-2.0/src/support httpd.exp
Date Sun, 03 Dec 2000 04:37:55 GMT
> From: []
> Sent: Friday, December 01, 2000 7:39 PM
> > > Unfortunately, after getting the normal code working I went into the
> > > WinNT MPM ('cause it too calls ap_new_connection()) and realized I
> > > needed to do some research about whether or not the APR socket (built
> > > via apr_put_os_sock()) is properly initialized on Windows.
> >
> >
> > We should probably toss the apr_put_os_* functions and call them something
> > like apr_os_make_*() and accept the particular OS object to construct the
> > APR type.

I think our existing apr_os_ functions make sense, and if you find a specific
discrepancy, note it here (such as I did for apr_put_os_dir, which was nonsense.)
> Two questions.  1)  Why the name change?  2)  What particular 
> OS object are you talking about?
> The reason I chose the apr_put_os_* name, is that it matches well with
> apr_get_os_*.  Not that its important, but I would like the two functions
> to be symetric, because they perform complimentary functions.

Made sense, although apr_from_os_bleh would make equal sense.  If we start
playing games with apr_from_FILE_, apr_from_HANDLE_, and apr_from_stream_ we
are getting too carried away, I'd suggest converting from the most base
type on a platform (HANDLE in the case of win32) and coding our way out
of a stream into a HANDLE before converting to APR.  This is what we do today.

View raw message