Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 4308 invoked by uid 500); 1 Dec 2000 01:11:45 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 4294 invoked from network); 1 Dec 2000 01:11:43 -0000 X-Authentication-Warning: kurgan.lyra.org: gstein set sender to gstein@lyra.org using -f Date: Thu, 30 Nov 2000 17:14:19 -0800 From: Greg Stein To: new-httpd@apache.org Subject: Re: cvs commit: apache-2.0/src/lib/sdbm sdbm.c sdbm_private.h Message-ID: <20001130171419.V25840@lyra.org> Mail-Followup-To: new-httpd@apache.org References: <20001201004648.92701.qmail@locus.apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: ; from rbb@covalent.net on Thu, Nov 30, 2000 at 05:01:46PM -0800 X-URL: http://www.lyra.org/greg/ X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N On Thu, Nov 30, 2000 at 05:01:46PM -0800, rbb@covalent.net wrote: > On 1 Dec 2000 gstein@locus.apache.org wrote: > > > gstein 00/11/30 16:46:47 > > > > Modified: src/lib/sdbm sdbm.c sdbm_private.h > > Log: > > Allocate the SDBM structure using malloc/free rather than a pool. register a > > pool cleanup as a backup, but allow "early freeing" via sdbm_close. > > > > Concept from Ryan Bloom. > > This is a start, but we are still using pools to allocate the file when we > do apr_open. This should be a NULL pool at this point, and all pools > should be completely removed from SDBM. For the next day or two, this > will leak memory a little bit, but I am in the middle of trying to fix all > of the memory leaks in APR that come about from using the NULL pool. No. It should continue to use a pool for the files. I absolutely refuse to pass NULL to apr_open() for this stuff. Leave it at that. -g -- Greg Stein, http://www.lyra.org/