Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 48084 invoked by uid 500); 3 Nov 2000 15:12:24 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 48034 invoked from network); 3 Nov 2000 15:12:13 -0000 Message-Id: <200011031511.CAA18924@silk.apana.org.au> From: "Brian Havard" To: "new-httpd@apache.org" Date: Sat, 04 Nov 2000 02:11:51 +1000 (EST) Reply-To: "Brian Havard" Priority: Normal X-Mailer: PMMail 2.10.1999 for OS/2 Warp 4.05 In-Reply-To: <20001103005529.58189.qmail@locus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: cvs commit: apache-1.3/src/modules/standard mod_autoindex.c X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N On 3 Nov 2000 00:55:29 -0000, wrowe@locus.apache.org wrote: > Log: > Resolve mod_autoindex caching problems by returning the mtime as the > Last-Modified tag, and assigning the ETag. Already applied to the > Apache 2.0 tree. [...] > --- mod_autoindex.c 2000/02/02 20:44:01 1.114 > +++ mod_autoindex.c 2000/11/03 00:55:28 1.115 > @@ -1615,7 +1615,10 @@ > } > > r->content_type = "text/html"; > - > + ap_update_mtime(r, r->finfo.st_mtime); > + ap_set_last_modified(r); > + ap_set_etag(r); I believe this fix relies on a file system behaviour that is not universal, that is the mtime of a directory is updated whenever a file in it is modified. Of the file systems I have on my machine here (FAT, HPFS, JFS) only JFS does this. I'll probably have to special case this on OS/2 as HPFS is the most commonly used file system on it. JFS is only available on the latest server version of OS/2, v4.5 aka "Warp Server for e-business". -- ______________________________________________________________________________ | Brian Havard | "He is not the messiah! | | brianh@kheldar.apana.org.au | He's a very naughty boy!" - Life of Brian | ------------------------------------------------------------------------------