Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 21470 invoked by uid 500); 10 Nov 2000 15:09:34 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 21454 invoked from network); 10 Nov 2000 15:09:33 -0000 Message-ID: <018701c04b28$14f9bca0$011aa8c0@godzilla> From: "David Reid" To: References: <009101c04ab4$bc8ba150$641aa8c0@godzilla><20001110025020.X3315@hand.dotat.at><001e01c04b05$ea7a57e0$011aa8c0@godzilla><00f601c04b16$3f473990$011aa8c0@godzilla><017501c04b26$ac595530$011aa8c0@godzilla> Subject: Re: apr_sockaddr_t Date: Fri, 10 Nov 2000 15:08:25 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.00.2919.6700 X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2919.6700 X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N > > > Consider reserving space for the port string directly in the > > > apr_sockaddr_t: > > > > > > char port_str[6]; > > > > This makes sense, but I wasn't sure what the biggest string we could have > > would be? Is 6 big enough? > > the largest UDP or TCP port is 65535, so max string length is 5 decimal > digits + terminating '\0' Yes, but what about for the named ports? If we have "telnet\0" that's 7, and is that the biggest? I was thinking of port_str being used for known ports as well as string representations (maybe I should change the comment?) and I wasn't sure what the longest would be. I see there is a define of NI_MAXSERV at 32, so would 32 be a suitable value and do we want to go that large? david